Skip to content

Commit

Permalink
Merge branch 'major-release' into enhancement/69/change-utility-class…
Browse files Browse the repository at this point in the history
…es-to-8px-grid
  • Loading branch information
rmccar authored Oct 8, 2024
2 parents 4daeeaf + fd60f80 commit 1588baf
Showing 1 changed file with 93 additions and 85 deletions.
178 changes: 93 additions & 85 deletions migration_guides/70.x.x-to-71.0.0-migration-guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,7 @@ This section will list the changes that will impact more than one component
- Video - `videoLinkURL` will need to be renamed `videoLinkUrl`
- Page Template - `assetsURL` will need to be renamed `assetsUrl`
- Footer - `OGLLink` will need to be renamed `oglLink`
- Footer - `oglLink.HTML` will need to be renamed `oglLink.html`
- Message - `messageID` will need to be renamed `messageId`
- Access Code - `maxlength` will need to be renamed `maxLength`
- Address input - `APIDomain` will need to be renamed `apiDomain`
Expand Down Expand Up @@ -322,6 +323,7 @@ This section will list the changes that will impact more than one component
}
})
}}

NEW
{{
onsHeader({
Expand Down Expand Up @@ -393,12 +395,12 @@ This section will list the changes that will impact more than one component
OLD
<div
class="ons-header__grid-top ons-grid ons-grid--flex ons-grid--between ons-grid--vertical-center ons-grid--no-wrap ons-grid--gutterless"
>
NEW
<div
class="ons-header__grid-top ons-grid ons-grid-flex ons-grid-flex--between ons-grid-flex--vertical-center ons-grid-flex--no-wrap ons-grid--gutterless"
></div>
</div>
></div>

NEW
<div
class="ons-header__grid-top ons-grid ons-grid-flex ons-grid-flex--between ons-grid-flex--vertical-center ons-grid-flex--no-wrap ons-grid--gutterless"
></div>
```

</details>
Expand Down Expand Up @@ -446,15 +448,15 @@ This section will list all the changes that are specific to one component.
OLD
{% from "components/onsMetadata/_macro.njk" import onsMetadata %}

{{-
{{
onsMetadata({ ... })
}}

NEW
{% from "components/description-list/_macro.njk" import onsDescriptionList %}

{{
onsDescriptionList({ ... })
onsDescriptionList({ ... })
}}
```

Expand Down Expand Up @@ -490,6 +492,7 @@ This section will list all the changes that are specific to one component.
}
})
}}

SUGGESTED REPLACEMENT
{% from "components/button/_macro.njk" import onsButton %}

Expand Down Expand Up @@ -555,16 +558,17 @@ This section will list all the changes that are specific to one component.
{{
onsMessageList({
"messages": [{
"url": "#0",
"subject": "survey response query",
"url": "#0",
"subject": "survey response query",
}]
})
}}

NEW
{{
onsMessageList({
"messages": [{
"subject":{
"messages": [{
"subject":{
"url": "#0",
"text":"survey response query",
}
Expand Down Expand Up @@ -598,6 +602,7 @@ This section will list all the changes that are specific to one component.
"poweredBy": "<svg></svg>"
})
}}

NEW
{{
onsFooter({
Expand Down Expand Up @@ -633,19 +638,19 @@ This section will list all the changes that are specific to one component.
OLD
{{-
onsFooter({
"OGLLink": {
"link": "www.google.com"
}
})
"OGLLink": {
"link": "www.google.com"
}
})
}}

NEW
{{
onsFooter({
"OGLLink": {
"text": "www.google.com"
}
})
"OGLLink": {
"text": "www.google.com"
}
})
}}
```

Expand Down Expand Up @@ -777,7 +782,7 @@ This section will list all the changes that are specific to one component.
- `summary.summaryTitle` is renamed to `summary.title`
- `group.groupTitle` is renamed to `group.title`
- `row.rowTitle` is renamed to `row.title`
- `row.rowItems` is renamed to `row.items`
- `row.rowItems` is renamed to `row.itemsList`
- `rowItem.rowTitle` is renamed to `item.title`
- `rowItem.rowTitleAttributes` is renamed to `item.titleAttributes`
- **Reason for change:** In this update, we are addressing an inconsistency in the naming of parameters within the summary component. This change aims to standardise the parameter names for clarity and consistency.
Expand Down Expand Up @@ -829,6 +834,7 @@ This section will list all the changes that are specific to one component.
]
})
}}

NEW
{{
onsSummary({
Expand All @@ -843,7 +849,7 @@ This section will list all the changes that are specific to one component.
{
"id": "sales-dates-row",
"title": "What are the dates of the sales period you are reporting for?",
"items": [
"itemsList": [
{
"id": "sales-dates",
"valueList": [
Expand Down Expand Up @@ -896,6 +902,7 @@ This section will list all the changes that are specific to one component.
"titleTag": "h3"
})
}}

NEW
{{
onsTimeline({
Expand Down Expand Up @@ -929,35 +936,35 @@ This section will list all the changes that are specific to one component.
<summary><b>Click for example</b></summary>

```njk
OLD
{{
onsDocumentList({
"url": '#0',
"title": 'ONS launches Integrated Data Service to boost government collaboration on data sharing',
"metadata": {
"type": {
"text": 'Press releases',
"ref": 'Ref 008052'
},
},
})
}}

NEW
{{
onsDocumentList({
"title": {
"text": 'ONS launches Integrated Data Service to boost government collaboration on data sharing',
"url": '#0'
},
"metadata": {
"object": {
"text": 'Press releases',
"ref": 'Ref 008052'
},
},
})
}}
OLD
{{
onsDocumentList({
"url": '#0',
"title": 'ONS launches Integrated Data Service to boost government collaboration on data sharing',
"metadata": {
"type": {
"text": 'Press releases',
"ref": 'Ref 008052'
},
},
})
}}

NEW
{{
onsDocumentList({
"title": {
"text": 'ONS launches Integrated Data Service to boost government collaboration on data sharing',
"url": '#0'
},
"metadata": {
"object": {
"text": 'Press releases',
"ref": 'Ref 008052'
},
},
})
}}
```

</details>
Expand All @@ -979,19 +986,19 @@ This section will list all the changes that are specific to one component.
<summary><b>Click for example</b></summary>

```njk
OLD
{{
onsCookiesBanner({
"settingsLinkTextURL": "/cookiesoverride",
})
}}

NEW
{{
onsCookiesBanner({
"settingsLinkURL": "/cookiesoverride",
})
}}
OLD
{{
onsCookiesBanner({
"settingsLinkTextURL": "/cookiesoverride",
})
}}

NEW
{{
onsCookiesBanner({
"settingsLinkURL": "/cookiesoverride",
})
}}
```

</details>
Expand Down Expand Up @@ -1052,21 +1059,21 @@ This section will list all the changes that are specific to one component.
"url": '#0'
"headingLevel": 2,
"titleClasses": "random-class"
},
"body":{
"id": 'text',
"text": 'How we keep your data safe and what happens to your personal information.',
"itemsList": [
{
"url": '#0',
"text": 'List item 1 about the census'
},
{
"url": '#0',
"text": 'List item 2 about the census'
}
]
}
},
"body":{
"id": 'text',
"text": 'How we keep your data safe and what happens to your personal information.',
"itemsList": [
{
"url": '#0',
"text": 'List item 1 about the census'
},
{
"url": '#0',
"text": 'List item 2 about the census'
}
]
}
})
}}
```
Expand Down Expand Up @@ -1133,24 +1140,25 @@ This section will list all the changes that are specific to one component.
"itemsList": [{
"title": "Section 1"
"anchors": [{
"title": "Sub section 1"
}]
"title": "Sub section 1"
}]
}]
})
}]
})
}}

NEW
{{
onsSectionNavigation({
"sections":[{
"itemsList": [{
"text": "Section 1"
"anchors": [{
"text": "Sub section 1"
}]
"text": "Sub section 1"
}]
}]
})
}]
})
}}
```

Expand Down

0 comments on commit 1588baf

Please sign in to comment.