Skip to content

Commit

Permalink
Update to Node 16 and minor updates to other DS dependencies (#2713)
Browse files Browse the repository at this point in the history
  • Loading branch information
rmccar authored Jul 17, 2023
1 parent 0db0263 commit 1e295b3
Show file tree
Hide file tree
Showing 8 changed files with 783 additions and 649 deletions.
2 changes: 1 addition & 1 deletion .babelrc
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"presets": [
["@babel/preset-env", {
"targets": {
"node": "14"
"node": "16"
}
}]
]
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/lighthouse-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ jobs:
with:
ref: ${{ github.event.pull_request.head.sha }}
- name: Read .nvmrc file
run: echo "##[set-output name=NVMRC;]$(cat .nvmrc)"
id: nvm
id: read-nvmrc-file
run: echo "nvmrc=$(cat .nvmrc)" >> $GITHUB_OUTPUT
- name: Install Node
uses: actions/setup-node@v1
with:
node-version: "${{ steps.nvm.outputs.NVMRC }}"
node-version: "${{ steps.read-nvmrc-file.outputs.nvmrc }}"
- name: Install dependencies
run: yarn install
- name: Build pages
Expand Down
10 changes: 7 additions & 3 deletions .github/workflows/npm-bundle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,17 @@ jobs:
build:
runs-on: ubuntu-latest
steps:
- name: Use Node.js 14.15.0
- name: Read .nvmrc file
id: read-nvmrc-file
run: echo "nvmrc=$(cat .nvmrc)" >> $GITHUB_OUTPUT
- name: Use Node.js
uses: actions/checkout@v2
with:
ref: ${{ github.event.release.target_commitish }}
- uses: actions/setup-node@v1
- name: Install Node
uses: actions/setup-node@v1
with:
node-version: 14.15.0
node-version: "${{ steps.read-nvmrc-file.outputs.nvmrc }}"
registry-url: https://registry.npmjs.org/
- run: yarn install
- run: git config --global user.name "${{ github.actor }}"
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,13 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
- name: Read .nvmrc file
id: read-nvmrc-file
run: echo "nvmrc=$(cat .nvmrc)" >> $GITHUB_OUTPUT
- name: Install Node
uses: actions/setup-node@v2
with:
node-version: '14'
node-version: "${{ steps.read-nvmrc-file.outputs.nvmrc }}"
- name: Install dependencies
run: yarn install
- name: Build templates
Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,13 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v2
- name: Read .nvmrc file
id: read-nvmrc-file
run: echo "nvmrc=$(cat .nvmrc)" >> $GITHUB_OUTPUT
- name: Install Node
uses: actions/setup-node@v2
uses: actions/setup-node@v1
with:
node-version: "14"
node-version: "${{ steps.read-nvmrc-file.outputs.nvmrc }}"
- name: Install dependencies
run: yarn install
- name: Run macro and script tests
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v14.15.0
v16.16.0
2 changes: 1 addition & 1 deletion src/components/call-to-action/_macro.njk
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"text": params.button.text,
"url": params.button.url,
"variants": "small"
})}}
}) }}
</div>
</div>
</div>
Expand Down
1,395 changes: 759 additions & 636 deletions yarn.lock

Large diffs are not rendered by default.

0 comments on commit 1e295b3

Please sign in to comment.