Skip to content

Commit

Permalink
Remove space from button newWindowDescription (#3363)
Browse files Browse the repository at this point in the history
  • Loading branch information
rmccar authored Sep 19, 2024
1 parent 55408c7 commit 82265a8
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/components/button/_macro.njk
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@
{%- endif -%}
</span>
{% if params.url and params.newWindow %}
<span class="ons-btn__new-window-description ons-u-vh"> ({{ params.newWindowDescription | default("opens in a new tab") }})</span>
<span class="ons-btn__new-window-description ons-u-vh">({{ params.newWindowDescription | default("opens in a new tab") }})</span>
{% endif %}
{% if params.buttonContext %}
<span class="ons-btn__context ons-u-vh">{{ params.buttonContext }}</span>
Expand Down
4 changes: 2 additions & 2 deletions src/components/button/_macro.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ describe('macro: button', () => {
}),
);

expect($('.ons-btn__new-window-description').text()).toBe(' (opens in a new tab)');
expect($('.ons-btn__new-window-description').text()).toBe('(opens in a new tab)');
});

it('has a custom new window description when `newWindow` is `true` and `newWindowDescription` is provided', () => {
Expand All @@ -405,7 +405,7 @@ describe('macro: button', () => {
}),
);

expect($('.ons-btn__new-window-description').text()).toBe(' (custom opens in a new window text)');
expect($('.ons-btn__new-window-description').text()).toBe('(custom opens in a new window text)');
});

it('has the `download` attribute when `variants` contains "download"', () => {
Expand Down

0 comments on commit 82265a8

Please sign in to comment.