Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/2176/options for reply component #2761

Merged
merged 6 commits into from
Jul 28, 2023

Conversation

willcAND
Copy link
Contributor

What is the context of this PR?

#2176

How to review

Modify example, confirm new parameters are available inside onsReply. Tests pass.

@willcAND willcAND self-assigned this Jul 26, 2023
@netlify
Copy link

netlify bot commented Jul 26, 2023

Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit 8749e61
🔍 Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/64c26266e2bd9f00080af33d
😎 Deploy Preview https://deploy-preview-2761--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@rmccar rmccar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but maybe we should add the limit and description to one of the examples too

@willcAND
Copy link
Contributor Author

Looks good but maybe we should add the limit and description to one of the examples too

I did try this originally, couldn't think of a good descriptive label for a reply message.. Will have another go and add back in.

@willcAND willcAND merged commit 5809edb into main Jul 28, 2023
7 checks passed
@willcAND willcAND deleted the enhancement/2176/options-for-reply-component branch July 28, 2023 12:50
@alessioventuriniAND alessioventuriniAND added the Enhancement Change of existing feature label Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Change of existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants