Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Button component test file to new format #3353

Open
wants to merge 36 commits into
base: main
Choose a base branch
from
Open

Refactor Button component test file to new format #3353

wants to merge 36 commits into from

Conversation

SriHV
Copy link
Contributor

@SriHV SriHV commented Sep 13, 2024 •
edited
Loading

What is the context of this PR?

139

Refactored the button macro.spec file as per the new format.

How to review this PR

Ask yourself....

  • Do we need any additional tests?
  • Are the tests descriptions clear?
  • Does the order of the test document make sense?
  • Is it internally consistent?
  • Is it consistent with the guidelines for test refactoring?

run this test command to view the test results:
yarn test --testNamePattern="FOR: button"

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Assignee
  • I have linked the correct Issue

@SriHV SriHV self-assigned this Sep 13, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 13, 2024 •
edited
Loading

✅ Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit 5a5c638
🔍 Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/66ffe7954de7770008e664ed
😎 Deploy Preview https://deploy-preview-3353--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SriHV SriHV linked an issue Sep 13, 2024 that may be closed by this pull request
Testing refactor - Button ONSdigital/design-team#139
Open
@SriHV SriHV added the Tech improvements Tech debt, cleanup, code standardisation etc. label Sep 13, 2024
@SriHV SriHV requested a review from a team September 17, 2024 09:56
@SriHV SriHV marked this pull request as ready for review September 17, 2024 09:56
rmccar
rmccar requested changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@rmccar rmccar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are mainly just minor things but it would be good to be consistent with the way we are writing these tests. We need to make sure we use the correct names for params and the tests describe what they are testing

src/components/button/_macro.spec.js Outdated Show resolved Hide resolved
src/components/button/_macro.spec.js Outdated Show resolved Hide resolved
src/components/button/_macro.spec.js Outdated Show resolved Hide resolved
src/components/button/_macro.spec.js Outdated Show resolved Hide resolved
src/components/button/_macro.spec.js Outdated Show resolved Hide resolved
src/components/button/_macro.spec.js Outdated Show resolved Hide resolved
src/components/button/_macro.spec.js Outdated Show resolved Hide resolved
src/components/button/_macro.spec.js Outdated Show resolved Hide resolved
src/components/button/_macro.spec.js Outdated Show resolved Hide resolved
src/components/button/_macro.spec.js Outdated Show resolved Hide resolved
@rmccar rmccar changed the title Refactor button test file to new format Refactor button component test file to new format Sep 19, 2024
@rmccar rmccar changed the title Refactor button component test file to new format Refactor Button component test file to new format Sep 27, 2024
@rmccar rmccar added the Do not merge Don't merge this PR until this label is removed label Oct 2, 2024
SriHV and others added 29 commits October 3, 2024 17:11
@SriHV @rmccar
Update src/components/button/_macro.spec.js
a2ed68a 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/button/_macro.spec.js
2f410d2 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/button/_macro.spec.js
84fe7b0 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/button/_macro.spec.js
6359eb2 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/button/_macro.spec.js
ae03def 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/button/_macro.spec.js
5ebc1c1 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/button/_macro.spec.js
70254b8 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/button/_macro.spec.js
bcc4316 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/button/_macro.spec.js
8b058aa 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/button/_macro.spec.js
3f19ff4 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/button/_macro.spec.js
c23e2cd 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/button/_macro.spec.js
219d8b5 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/button/_macro.spec.js
76f67ee 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/button/_macro.spec.js
eaa1f07 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/button/_macro.spec.js
1b56c6a 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/button/_macro.spec.js
7f4877f 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/button/_macro.spec.js
ca842c9 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/button/_macro.spec.js
e03f158 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/button/_macro.spec.js
52be6c3 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/button/_macro.spec.js
035fbce 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/button/_macro.spec.js
31b1311 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/button/_macro.spec.js
7c47f8a 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/button/_macro.spec.js
dd9bc1f 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/button/_macro.spec.js
67a25b1 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/button/_macro.spec.js
499001f 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/button/_macro.spec.js
7afdd9d 
Co-authored-by: rmccar <[email protected]>
@SriHV @rmccar
Update src/components/button/_macro.spec.js
a93e8af 
Co-authored-by: rmccar <[email protected]>
@SriHV
changes as per comments
dea8095
@SriHV
changes as per comments
5a5c638
@rmccar rmccar removed the Do not merge Don't merge this PR until this label is removed label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmccar rmccar rmccar requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@SriHV SriHV

Labels
Tech improvements Tech debt, cleanup, code standardisation etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Testing refactor - Button
3 participants
@SriHV @rmccar @alessioventuriniAND