Flush stdout kwarg #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Added
flush_sdout_after_log_entrykwag to dp logger. By default it is set to false. when it is set to true it will flush the buffer after each logging statementAdditional Info: "logs are getting concatenated (so 2 or more logging statements can get sent to cloudwatch as a single event via glue). This is messy and will cause a lot of issues if/when we move into the world of logging to elastic search/kibana.
This is happening because more than one log message gets sent to the buffer (memory for standard out) before it gets flushed (printed to console)."
How to review
check the logic or any typo's
Who can review
Anyone