Extend validator to support new field, 'sds_schema_version' #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Validator needed to be extended to support a new
sds_schema_versionfield. The changes added are needed to align with the SDS and Authors teams to automate the release of SDS schema definitions versions.sds_schema_versionis not currently set in any schema in Runner, thus it will cause schema validation to fail. In order to support this new field,questionnaire_v1.jsonwas updated to include this value as a property at the top level. Additionally, it hasn't been marked as a required field as we want to support the schemas which currently do not use this field.How to review
update-sds-schema-validation- which includes the new field)Checklist