Upgrade to Python 3.11 #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmccar
force-pushed
the
upgrade-to-python-3.11
branch
from
18152ef
to
0ef717e
Compare
There was a problem hiding this comment.
The Cloud function's Python need updating. Looks like previous updates missed it: https://github.com/ONSdigital/eq-submission-confirmation-consumer/blob/main/scripts/deploy_function.sh#L2-L4
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Given the issue has been fixed, this repo this updating: https://github.com/ONSdigital/eq-translations/pull/98/files#diff-230078d672f10d17463a8a6265cad825b790885898256a3365be90685caac58dR21-R22 |
petechd
approved these changes
Sep 21, 2023
katie-gardner
approved these changes
Sep 21, 2023
ONSdigital/eq-translations#101 PR to fix this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Upgrade to Python 3.11
Also updates Github actions to use setup-python@v4 and checkout@v3 because v2 uses node 12.
I needed to update the ubuntu version and pin the pylint version to latest to get the action to pass due to the dill and wrapt dependancy errors
How to review
Checklist
*[ ] Tests updated