Merge pull request #90 from ONSdigital/437-runid-fix

run id fix
ONSdigital · Sep 21, 2023 · b41a8b2 · b41a8b2
2 parents c5fc825 + 1e07146
commit b41a8b2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/src/developer_config.yaml b/src/developer_config.yaml
@@ -23,14 +23,15 @@ runlog_writer:
     log_path: "data/log"
 hdfs_paths:
   root: None
-  logs_foldername: "resdev/logs/run_logs"
+  logs_foldername: "/ons/rdbe_dev/logs/run_logs"
   snapshot_path: "/ons/rdbe_dev/snapshot-202012-002-fba5c4ba-fb8c-4a62-87bb-66c725eea5fd.json"
   postcode_masterlist: "/ons/rdbe_dev/mappers/2023/ONSPD_NOV_2022_UK.csv"
   postcode_path: "/ons/rdbe_dev/staging/staging_qa/postcode_validation"
   pg_mapper_path: "/ons/rdbe_dev/mappers/2023/SIC_to_PG_UTF-8.csv"
   ultfoc_mapper_path: "/ons/rdbe_dev/mappers/2023/BERD_2022_ultfoc_anon.csv"
   cora_mapper_path: "/ons/rdbe_dev/mappers/2023/cora_mapper.csv"
   staging_output_path: "/ons/rdbe_dev/staging/staging_qa/full_responses_qa"
+  output_path:  "/ons/rdbe_dev/outputs"
   cellno_path: "/ons/rdbe_dev/mappers/2023/berd_2022_cellno_coverage.csv"
   itl_path: "/ons/rdbe_dev/mappers/2023/itl.csv"
   history_path: "/ons/rdbe_dev/BERD_V7_Anonymised"

diff --git a/src/utils/runlog.py b/src/utils/runlog.py
@@ -36,11 +36,8 @@ def __init__(
         self.timestamp = self._generate_time()
 
     def _make_main_path(self):
-        """Creating a local runlog folder if it doesn't exist"""
-        if self.environment == "hdfs":
-            logs_folder = f"/user/{self.user}/{self.logs_folder}"
-        elif self.environment == "network":
-            logs_folder = self.logs_folder
+        """Returns the log folder from the config"""
+        logs_folder = self.logs_folder
         return logs_folder
 
     def _create_folder(self):