Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Buildroot, EDK2 and QEMU #180

Merged
merged 3 commits into from
Mar 18, 2021
Merged

Update Buildroot, EDK2 and QEMU #180

merged 3 commits into from
Mar 18, 2021

Conversation

xiangmy
Copy link
Contributor

@xiangmy xiangmy commented Mar 18, 2021

As disscussed in #179

  • Buildroot fixed the glibc 2.33 compatibility issue (_STAT_VER was removed in glibc 2.33), we should upgrade the Buildroot to reflect that change.
  • EDK2 fixed its incompatibility with python 3.9, so we should update it to edk2-stable202102
  • QEMU fails to build with binutils 2.35 (https://bugs.launchpad.net/ubuntu/+source/binutils/+bug/1907789), hence, we need to update it to the latest version.

Copy link
Contributor

@jforissier jforissier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split into 3 commits, one for each component you are upgrading.
And see my comment below. Thanks!

default.xml Show resolved Hide resolved
@jforissier
Copy link
Contributor

  • For commit "Update Buildroot":
    Please specify the version in the commit subject: "Update Buildroot to version 2021.02". With that:
    Acked-by: Jerome Forissier <[email protected]>
  • For commit "Update EDK2":
    Please add prefix: "qemu_v8: update EDK2". With that:
    Acked-by: Jerome Forissier <[email protected]>
  • For commit "Update QEMU":
    Please add prefix: "qemu, qemu_v8: update QEMU". With that:
    Acked-by: Jerome Forissier <[email protected]>

Mainline EDK2 is also used by fvp.xml, perhaps someone who can test it can try to upgrade?

@jforissier
Copy link
Contributor

Small nit: no blank lines should be added between tags (Link:, Signed-off-by:, Acked-by: etc.).

xiangmy added 3 commits March 18, 2021 17:18
As Buildroot fixed [1] the glibc 2.33 compatibility issue, we should update
the Buildroot to reflect that change.

Link: [1] https://git.busybox.net/buildroot/commit/?id=f45925a951318e9e53bead80b363e004301adc6f
Signed-off-by: Mingyuan Xiang <[email protected]>
Acked-by: Jerome Forissier <[email protected]>
EDK2 fixed its incompatibility with python 3.9 with [1], [2], and [3],
so we should update it to edk2-stable202102.

Link: [1] tianocore/edk2@5d86483
Link: [2] tianocore/edk2@43bec9e
Link: [3] tianocore/edk2@20b292d
Signed-off-by: Mingyuan Xiang <[email protected]>
Acked-by: Jerome Forissier <[email protected]>
QEMU fails to build with binutils 2.35 [1] (fixed in [2]),
hence, we need to update it to the latest version.

Link: [1] https://bugs.launchpad.net/ubuntu/+source/binutils/+bug/1907789
Link: [2] qemu/qemu@bbd2d5a812
Signed-off-by: Mingyuan Xiang <[email protected]>
Acked-by: Jerome Forissier <[email protected]>
@xiangmy
Copy link
Contributor Author

xiangmy commented Mar 18, 2021

Got you! Thanks for the reviewing!

@jforissier jforissier merged commit df8e193 into OP-TEE:master Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants