libckteec: one shot encryption/decryption may have no input data #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jforissier
reviewed
Feb 12, 2024
etienne-lms
force-pushed
the
pkcs11-fix
branch
from
fc09013 to
cf8c720
Compare
|
Review tag applied. Thanks. |
Change the one shot encryption and decryption handler function to allow input buffer reference to be NULL. This may happen for example with AES GCM operation where encryption of a NULL buffer is expected to produce an AES GCM authentication tag. Before this change, providing a NULL buffer to C_Encrypt() made ckteec_register_shm() to fail and ckteec_register_shm() to return CKR_HOST_MEMORY error code. Fixes: aa3dd58 ("libckteec: Allow 0 length input buffer for update operations.") Acked-by: Jerome Forissier <[email protected]> Signed-off-by: Etienne Carriere <[email protected]>
|
I saw a minor issue in the commit message. Referred commit header line is wrong: -Fixes: aa3dd58d605e ("libckteec: Allow 0 length input buffer for update operations;")
+Fixes: aa3dd58d605e ("libckteec: Allow 0 length input buffer for update operations.")I'll force push an fixed commit. |
etienne-lms
force-pushed
the
pkcs11-fix
branch
from
cf8c720 to
0e0fd21
Compare
|
Rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the one shot encryption and decryption handler function to allow input buffer reference to be NULL. This may happen for example with AES GCM operation where encryption of a NULL buffer is expected to produce an AES GCM authentication tag. Before this change, providing a NULL buffer to C_Encrypt() made ckteec_register_shm() to fail and ckteec_register_shm() to return CKR_HOST_MEMORY error code.
Fixes: aa3dd58 ("libckteec: Allow 0 length input buffer for update operations;")