Rename fix and add pkgconfig files #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, only minor comments.
Anyways: Thanks! |
eaaltonen
force-pushed
the
pkgconfig-files
branch
from
3255192 to
b91e27c
Compare
|
Missed the notification.
Fine by me. I don't need it myself. Removed.
Agree and reworded. Also |
etienne-lms
reviewed
Mar 11, 2024
eaaltonen
force-pushed
the
pkgconfig-files
branch
from
b91e27c to
3f4ea2d
Compare
fixed, thanks. |
etienne-lms
reviewed
Mar 13, 2024
Switch naming convention of the pkgconfig metadata file use the plain namespec without the lib prefix. While both forms are permitted, the man page of pkg-config[1] has more examples of metadata files without a lib prefix. Similarly the uuid metadata file that teeacl uses to link is named simply `uuid.pc`. Additionally the lib prefix does not provide extra information, and long lists of pkgconfig metadata files are easier to read with just the plain namespec. [1]: https://linux.die.net/man/1/pkg-config Signed-off-by: Eero Aaltonen <[email protected]> Acked-by: Jerome Forissier <[email protected]> Acked-by: Etienne Carriere <[email protected]>
pkg-config --static --libs includes the libraries specified in Libs, so there's no need to repeat them in Libs.private. Signed-off-by: Eero Aaltonen <[email protected]> Acked-by: Jerome Forissier <[email protected]> Acked-by: Etienne Carriere <[email protected]>
Add a pkgconfig file to libteeacl, so that the library and its headers can be found from wherever they have been installed. Signed-off-by: Eero Aaltonen <[email protected]> Acked-by: Jerome Forissier <[email protected]> Acked-by: Etienne Carriere <[email protected]>
eaaltonen
force-pushed
the
pkgconfig-files
branch
from
3f4ea2d to
8475993
Compare
acked-by, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename libteec pkgconfig file, add backwards compatiblity option and drop redundant flag.
Add pkgconfig file for libteeacl.
Note: The URL field in the generated pkgconfig-file is now empty for both
teeacl.pcandteec.pc. I kept it for now, but it could be either be removed altogether or populated.