optee ftpm: CFG_TA_FTPM_RPMB_STORAGE selects RPMB storage #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sub.mk
Outdated
| @@ -95,6 +96,8 @@ srcs-y += platform/fTPM_helpers.c | |||
|
|
|||
| srcs-y += fTPM.c | |||
|
|
|||
| cflags-$(CFG_TA_FTPM_RPMB_STORAGE) += -DCFG_TA_FTPM_RPMB_STORAGE | |||
etienne-lms
commented
Dec 13, 2024
sub.mk
Outdated
| @@ -1,4 +1,5 @@ | |||
| CFG_FTPM_EMULATE_PPI ?= n | |||
| CFG_TA_FTPM_RPMB_STORAGE ?= n | |||
There was a problem hiding this comment.
Maybe the configuration should get the storage ID instead of a a boolean value that selects between TEE_STORAGE_PRIVATE and TEE_STORAGE_PRIVATE_RPMB. Here:
CFG_FTPM_TA_TEE_STORAGE_ID ?= TEE_STORAGE_PRIVATE
Adds configuration switch CFG_TA_FTPM_RPMB_STORAGE that, when enable, makes fTPM OP-TEE TA to explicitly use the eMMC RPMB secure storage of OP-TEE instead of OP-TEE private storage which depends on OP-TEE configuration. The configuration switch is default disabled for compatibility reasons. Signed-off-by: Etienne Carriere <[email protected]> Reviewed-by: Jens Wiklander <[email protected]>
etienne-lms
force-pushed
the
secstore
branch
from
4d48562 to
85bc88d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds configuration switch CFG_TA_FTPM_RPMB_STORAGE that, when enable, makes fTPM OP-TEE TA to explicitly use the eMMC RPMB secure storage of OP-TEE instead of OP-TEE private storage which depends on OP-TEE configuration. The configuration switch is default disabled for compatibility reasons.