drivers: change tree trace level #7074
Conversation
|
Hi Pascal, could specify in commit messages which xtest you're referring to (the one linked with PTA stats). |
There was a problem hiding this comment.
I think it is a legitimate change. Enabling debug trace level may generate quite many trace messages.
Could you also update the header files:
clk.h:
/**
* clk_print_tree() - Print current clock tree summary to output console
*
- * The clock is printed with the debug trace level.
+ * The clock is printed with the info trace level.
*/regulator.h:
-/* Print current regulator tree summary to console with debug trace level */
+/* Print current regulator tree summary to console with info trace level */and mk/config.mk:
# CFG_DRIVERS_CLK_PRINT_TREE embeds a helper function to print the clock tree
-# state on OP-TEE core console with the debug trace level.
+# state on OP-TEE core console with the info trace level.
(...)
# CFG_DRIVERS_REGULATOR_PRINT_TREE embeds a helper function to print the
# regulator tree state on OP-TEE core console with the info trace level.(note that info level was already mentioned for regulator tree traces :)
core/drivers/clk/clk.c
Outdated
| if (IS_ENABLED(CFG_DRIVERS_CLK_PRINT_TREE) && | ||
| TRACE_LEVEL >= TRACE_DEBUG) { | ||
| DMSG("Clock tree summary (informative):"); | ||
| if (IS_ENABLED(CFG_DRIVERS_CLK_PRINT_TREE)) { |
There was a problem hiding this comment.
Removing test on TRACE_LEVEL >= TRACE_INFO makes that when CFG_DRIVERS_CLK_PRINT_TREE is enabled but TRACE_LEVEL to low, there will be useless code embedded.
I would be in favor of restoring this test.
Ditto in core/drivers/regulator/regulator.c.
Change clock trace level of print tree so that it can bee seen when it is requested by xtest --stats --clocks. Signed-off-by: Pascal Paillet <[email protected]> Acked-by: Gatien Chevallier <[email protected]>
Change regulator trace level of print tree so that it can bee seen when it is requested by xtest --stats --regulators. Signed-off-by: Pascal Paillet <[email protected]> Acked-by: Gatien Chevallier <[email protected]>
done, thank you! |
|
Hi @jforissier, could you enable CI tests for this P-R? |
|
|
Change the clock and regulator trace level of the print tree functions so that they can be seen when requested by xtest without needing to activate all debug traces.