ta: cleanup trace messages in test TAs #710
Conversation
There was a problem hiding this comment.
Global comments: in the commit description, the best practise is to use the imperative tone. This means no third person "s" in the verbs. e.g. s/Uses/Use/g, s/Adds/Add/g, s/Removes/Remove/g and so on.
Reference: https://www.kernel.org/doc/html/v4.10/process/submitting-patches.html#describe-your-changes
Describe your changes in imperative mood, e.g. “make xyzzy do frotz” instead of “[This patch] makes xyzzy do frotz” or “[I] changed xyzzy to do frotz”, as if you are giving orders to the codebase to change its behaviour.
ta/os_test/include/tb_macros.h
Outdated
| EMSG("\n*** FAILED ***" \ | ||
| "\nTestbench halted at line %d in function %s"; \ |
There was a problem hiding this comment.
| EMSG("\n*** FAILED ***" \ | |
| "\nTestbench halted at line %d in function %s"; \ | |
| EMSG("\n*** FAILED ***" \ | |
| "\nTestbench halted at line %d in function %s"; \ |
Fix the alignment.
|
Thanks @vincent-mailhol for the review.
@jforissier, @jbech-linaro, is this the preferred phrasing in OP-TEE repos commits? |
Yes. |
|
comments addressed. |
|
@vincent-mailhol, maybe you want to post a review tag for this series? |
I am fine with the contents. But my main comment is on the commit description and I do not see changes. This is why I have not given my review tag yet. |
|
Ok, thanks for the feedback . I'll squash the fixup commits right away. |
|
Done |
|
For the series:
Thank you. |
indeed! |
|
PR probably needs a rebase as well, since we see the pkcs11 1007 error here as well. |
Use PRI* specifiers in trace messages using xMSG() macros. Add parentheses to explicit function labels. Remove function label from EMSG() trace messages as the macro already takes care of printing it. Reviewed-by: Joakim Bech <[email protected]> Reviewed-by: Vincent Mailhol <[email protected]> Signed-off-by: Etienne Carriere <[email protected]>
Use PRI* specifiers in trace messages using xMSG() macros and fix indentation issues. Reviewed-by: Joakim Bech <[email protected]> Reviewed-by: Vincent Mailhol <[email protected]> Signed-off-by: Etienne Carriere <[email protected]>
Use PRI* specifiers in trace messages using xMSG() macros and fix indentation issues. Reviewed-by: Joakim Bech <[email protected]> Reviewed-by: Vincent Mailhol <[email protected]> Signed-off-by: Etienne Carriere <[email protected]>
Replace printf() occurrences with use of MSG() macro in TA implementation source and header files. MSG() macro already prints the function label and the line number hence remove these explicit arguments from trace messages printed by HALT() macro. Use PRI* specifiers in trace messages using xMSG() macros. Add parentheses to function names in trace message where applicable to explicit these are function labels. Add an empty line in implementation of DEF_BIGINT() macro to comply with OP-TEE coding style. Reviewed-by: Joakim Bech <[email protected]> Reviewed-by: Vincent Mailhol <[email protected]> Signed-off-by: Etienne Carriere <[email protected]>
|
Rebased. IBART test seems ok. Thanks. |
|
ok to merge? |
This is a follow up of cleanup changes initiated in #708 and #709 to have TA trace messages implementation more consistent with OP-TEE coding style and trace resources.