pkcs11_1007: close session before trying new ones #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that I'm not 100% this change will fix OP-TEE/optee_os#6952. At least it should not be harmful. |
host/xtest/pkcs11_1000.c
Outdated
| rv = C_CloseSession(~0); | ||
| ADBG_EXPECT_CK_RESULT(c, CKR_SESSION_HANDLE_INVALID, rv); | ||
|
|
||
|
|
There was a problem hiding this comment.
Please remove one of the empty lines.
etienne-lms
force-pushed
the
pkcs11-fix2
branch
from
3175872 to
7937c12
Compare
Close opened sessions after secure service memory is exhausted before testing closure on invalid session. This change attempts to fix a non systematic issue found as described in [1]. A test case is slightly changed: where a likely invalid session ID (valid ID + 1024) was tried to be closed, this change now tries to close a session that has been already closed. Link: OP-TEE/optee_os#6952 [1] Signed-off-by: Etienne Carriere <[email protected]> Acked-by: Jens Wiklander <[email protected]>
etienne-lms
force-pushed
the
pkcs11-fix2
branch
from
7937c12 to
03d6783
Compare
|
Comment addresses + fix commit message (s/session/sessions/ x2) + apply review tag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close opened session after secure service memory is exhausted before testing closure on invalid session. This change attempts to fix a non systematic issue found as described in [1].
A test case is slightly changed: where a likely invalid session ID (valid ID + 1024) was tried to be closed, this change now tries to close a session that has been already closed.
Link: OP-TEE/optee_os#6952 [1]