-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regression: add case 1041 for fTPM #766
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed-by: Jerome Forissier <[email protected]>
* LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING | ||
* NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS | ||
* SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The whole license text is not really welcome, but I suppose you prefer to have an exact copy of the header file from the fTPM TA tree?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the problem is that the license text isn't identical to the boilerplate at https://spdx.org/licenses/BSD-2-Clause.html since they have [1] at the top. We could perhaps keep [1] and drop the rest since the rest only differs by omitting the numbers if I'm not mistaken.
[1]:
* The copyright in this software is being made available under the BSD License,
* included below. This software may be subject to other third party and
* contributor rights, including patent rights, and no such rights are granted
* under this license.
Removed the license part as proposed above, and tag applied. |
The CI error should be addressed by #767. |
* Copyright (c) 2024 Linaro Limited | ||
* | ||
* The copyright in this software is being made available under the BSD License, | ||
* included below. This software may be subject to other third party and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"included below" should be rephrased :(
Maybe:
* The copyright in this software is being made available under the BSD-2-Clause
* License. This software may be subject to other third party and
* ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Argh, that's changing the license text. I'll restore the removed portion.
Restored the removed part of the license text. |
|
Add regression case 1041 to test if the system has a fTPM TA and if so check that it has been probed. Signed-off-by: Jens Wiklander <[email protected]> Reviewed-by: Jerome Forissier <[email protected]> Acked-by: Etienne Carriere <[email protected]>
Tag applied. |
Add regression case 1041 to test if the system has a fTPM TA and if so check that it has been probed.