Adds support for the RCMASTS keyword #4272
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins build this opm-simulators=5620 please |
hakonhagland
commented
Oct 21, 2024
| const std::map<std::string, Slave>& slaves() const { | ||
| return this->m_slaves; | ||
| } | ||
| std::map<std::string, Slave>& slaves() { |
There was a problem hiding this comment.
The change here is that these methods was sorted alphabetically.
| return this->m_master_groups; | ||
| } | ||
|
|
||
| double masterMinTimeStep() const { |
There was a problem hiding this comment.
The following two methods were added to access the minimum timestep
| // ---------------------------------------------- | ||
| // Testing SLAVES keyword (sorted alphabetically) | ||
| // ---------------------------------------------- | ||
| BOOST_AUTO_TEST_SUITE(SlaveTests) |
There was a problem hiding this comment.
Added sub test suites to structure this file and make it more readable
|
|
||
| BOOST_AUTO_TEST_CASE(SLAVES_OK) { | ||
| BOOST_AUTO_TEST_CASE(FAIL_NEGATIVE_NUMPROCS) { |
There was a problem hiding this comment.
Also sorted the functions alphabetically
|
jenkins build this please |
Adds support for the RCMASTS keyword.
|
jenkins build this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the
RCMASTSkeyword in reservoir coupling.