Rewrite docker scripts in Python #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using a combination of Bash and PowerShell scripts, write the scripts as a Python project. This will help reducing code duplication between Bash and PowerShell scripts, and allow for easier extension to more than a single container.
lisajulia
reviewed
Feb 13, 2024
|
Only concern was resolved. I interpret this as approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using a combination of Bash and PowerShell scripts, this PR rewrites the scripts as a Python project. This will help reducing code duplication between Bash and PowerShell scripts, and also allow for easier extension to more than a single container in the future.
Currently, there is only one Docker image (ubuntu2204-lo7.5.9) but we might extend this to include, for example, an image for a development version of LibreOffice with debugging symbols in the future. This rewrite of the scripts in Python should make it easier to add this in the future.