Pass optional variable allow_deactive_cells=true to grid constructor #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 4, 2019
joakim-hove
force-pushed
the
iopm-grid-api-changes
branch
from
997acd8 to
89d76dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Downstream of OPM/opm-common#1059 and OPM/opm-grid#393
The grid construction process employed in opm/flow is a three step process:
EclipseGrid(deck)EclipseStatePORVproperty derived from theEclipseStateand deactivate cells with small pore volume.When the grid is constructed in this way the distribution of active cells should be correct already in the
EclipseGrid, and the processing to create aDune::cpGridshould not alter the set of (active) cells. With the PR set originating in OPM/opm-common#1059 we exploit this to do some simplifications, and furthermore add a hard check inopm-grid:processEclipseFormat()that no cells have been deactivated. Unfortunately the grid construction in opm-upscaling only contains the first step above, and the grid processing in opm-grid can disable additional cells. This PR passes a newallow_deactive_cells=trueflag to theprocessEclipseFormat()function.Yes - I know it is ugly :-(