New uncertainty characterisation updates #100
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erisation (if using the NetCDF LUTs) and the old approach. Also added deallocation of Sy output arrays and removed uncessary scale_factor and offset attributes from integer NetCDF variables.
adamcpovey
requested changes
Aug 20, 2024
| trim(adjustl(input_num)) | ||
| input_dummy2='measurement uncertainty in channel no '// & | ||
| trim(adjustl(input_num)) | ||
| input_dummy3='kelvin' |
There was a problem hiding this comment.
Don't these just repeat the block immediately before the if?
| @@ -1582,8 +1582,6 @@ subroutine def_output_primary(ncid, dim3d_var, output_data, indexing, & | |||
| long_name = 'number of retrieval iterations', & | |||
| standard_name = '', & | |||
| fill_value = byte_fill_value, & | |||
| scale_factor = output_data%niter_scale, & | |||
| add_offset = output_data%niter_offset, & | |||
There was a problem hiding this comment.
Good idea. Should also delete them from the output_data structure.
| chan_tmp_real(solar_indices(i)) !** 2 | ||
| ! Ensure SNR is explicitly set to 0 (used to determine if ru2 | ||
| ! should be used in get_measurments) | ||
| SAD_Chan(Ctrl%Ind%YSolar(i))%Solar%SNR = 0.0 |
There was a problem hiding this comment.
Isn't this done on line 1198?
| SAD_Chan(ii)%Solar%F0) / Pi | ||
| !Lx = (SPixel%Ym(i) * cos(SPixel%Geom%SolZen(j) * d2r) * & | ||
| ! SAD_Chan(ii)%Solar%F0) / Pi | ||
| Lx = (100.0 * SPixel%Ym(i) * SAD_Chan(ii)%Solar%F0) / Pi |
There was a problem hiding this comment.
Add a comment explaining why we're removing the \cos\theta. We won't remember next time we go to war with The Angles.
| @@ -1225,8 +1228,12 @@ subroutine Read_NCDF_SAD_LUT(Ctrl, LUTFilename, SAD_Chan, SAD_LUT) | |||
| ! Uncertainty = a**2 L**2 + b**2 L + c**2 | |||
| call ncdf_read_array(fid, "ru"//char(j+96), chan_tmp_real) | |||
| do i = 1, Ctrl%Ind%NSolar | |||
| ! ru values stored in LUT already squared?! | |||
There was a problem hiding this comment.
The units in the files agree with you here. I shall check what Don meant.
There was a problem hiding this comment.
Don says the values are not squared and so they need to be here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a Ctrl variable for switching between the new measurement uncertainty characterisation (if using the NetCDF LUTs) and the old approach.
Also added deallocation of Sy output arrays, and removed unnecessary scale_factor and offset attributes from integer NetCDF variables.