Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python interfaces for LUTs and a forward model implementation #85

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adamcpovey
Copy link
Collaborator

This adds,

  • pyorac.lut, Python containers for both text and NCDF look-up tables;
  • pyorac.fm, a Python implementation of the ORAC forward model;
  • pyorac.util.bound_grid and bilinear_coefficients, which are used by the forward model routines for interpolating LUTs;
  • two Jupyter notebooks demonstrating the use of the above.

I'm not done with this yet, but enough of it works I felt I should throw the code out there for people to look at. Can anyone actually work out how to run the examples? Would they be better as PDFs or hosted somewhere else where I can embed the files alongside? Do any of these things look useful?

This adds,
- pyorac.lut, Python containers for both text and NCDF look-up tables;
- pyorac.fm, a Python implementation of the ORAC forward model;
- pyorac.util.bound_grid and bilinear_coefficients, which are used by
  the forward model routines for interpolating LUTs;
- two Jupyter notebooks demonstrating the use of the above.
@adamcpovey adamcpovey self-assigned this Jun 22, 2023
@adamcpovey
Copy link
Collaborator Author

@garethethomas considering the two people I asked for opinions on this don't work for us any more, who should I throw it to? Elisa or Dora seem the most likely to actually want a Python forward model.

@simonrp84
Copy link
Collaborator

I never looked at this as I didn't have a need for a forward model outside ORAC.

That said, I've just taken a quick look at the code and it looks OK....aside from various linting issues. I strongly suggest running this through pylint or similar to highlight issues. There's a few places where uninitialised values are used, or class variables aren't referred to with self. etc. VSCode or PyCharm will be able ot fix almost all of these automagically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants