Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize boundary condition options #125

Merged
merged 6 commits into from
Aug 16, 2024
Merged

Generalize boundary condition options #125

merged 6 commits into from
Aug 16, 2024

Conversation

streeve
Copy link
Collaborator

@streeve streeve commented Aug 8, 2024 •
edited
Loading

  1. Separates geometry from region for BC; adds cylinder as additional example
  2. Simplification for cases of only one plane
  3. Unify interface to use time in all BC
  4. Adds options for user-defined regions or a boundary index space (for full customization)

Currently partially embedded in #108

@streeve streeve self-assigned this Aug 8, 2024
streeve
streeve commented Aug 16, 2024
View reviewed changes
src/CabanaPD_Boundary.hpp Show resolved Hide resolved
examples/mechanics/kalthoff_winkler.cpp Show resolved Hide resolved
src/CabanaPD_Boundary.hpp Show resolved Hide resolved
src/CabanaPD_Boundary.hpp Show resolved Hide resolved
src/CabanaPD_Boundary.hpp Show resolved Hide resolved
src/CabanaPD_Boundary.hpp Show resolved Hide resolved
src/CabanaPD_Boundary.hpp Outdated Show resolved Hide resolved
@streeve streeve merged commit ca667e4 into ORNL:main Aug 16, 2024
14 checks passed
@streeve streeve deleted the generalize_bc branch August 16, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pabloseleson pabloseleson pabloseleson approved these changes

Assignees

@streeve streeve

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@streeve @pabloseleson