Dual horizon PD #146
Open
Dual horizon PD #146
+482
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Pablo Seleson <[email protected]>
streeve
reviewed
Nov 8, 2024
| _init_timer.stop(); | ||
| } | ||
|
|
||
| void init_dual_mu() |
There was a problem hiding this comment.
I think this should be in the DHPD class?
| @@ -662,6 +682,8 @@ class SolverFracture | |||
|
|
|||
| using NeighborView = typename Kokkos::View<int**, memory_space>; | |||
| NeighborView mu; | |||
| NeighborView dual_mu; // Bond damage for dual horizon | |||
There was a problem hiding this comment.
Same here - should be below in the DHPD class
| @@ -225,7 +225,7 @@ template <class ForceType, class ParticleType, class NeighListType, | |||
| class NeighborView, class ParallelType> | |||
| void computeForce( ForceType& force, ParticleType& particles, | |||
| const NeighListType& neigh_list, NeighborView& mu, | |||
| const ParallelType& neigh_op_tag ) | |||
| double multiplier, const ParallelType& neigh_op_tag ) | |||
There was a problem hiding this comment.
Can put this last and default to 1.0 to make things simpler throughout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of DHPD.
This still hasn't been tested yet, I also have just copied the normal neighbour list for the dual neighbour list since variable horizon calculation is not yet available on the Cabana level.
Let me know if anything stand out in this, we can also test it by running a normal PD simulation with half the bond constant and it should arrive to the same solution as normal PD.
Relevant changes are in solver, force and force_PMB.hpp