Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update tls params for simulator #1426

Merged
merged 2 commits into from
Oct 7, 2024
Merged

update tls params for simulator #1426

merged 2 commits into from
Oct 7, 2024

Conversation

natasja-n
Copy link
Contributor

@natasja-n natasja-n commented Oct 4, 2024 •
edited
Loading

@natasja-n natasja-n changed the title catch exception in clearDlmsAttributeValues() on update cxf version update tls params for simulator Oct 4, 2024
jboon
jboon previously approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@jboon jboon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Op de oude code zitten een tweetal sonar suppressions. Dat is waarschijnlijk de oorzaak van de D-rating die je nu krijgt.

@natasja-n
add lost SuppressWarnings S4830
a999722 
Signed-off-by: Natasja Nortier <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@natasja-n natasja-n merged commit 1d13b48 into development Oct 7, 2024
7 checks passed
@natasja-n natasja-n deleted the bug/fix_gxf-apps-smart-metering-integration-nightly-build branch October 7, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jboon jboon jboon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@natasja-n @jboon