-
-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EXPERIMENTAL] v.colors: Histogram equalization #1392
base: main
Are you sure you want to change the base?
Conversation
Method
Issues |
In fact, these two commands don't work either: v.colors map=censusblk_swwake use=attr column=TOTAL_POP color=blues -g
v.colors map=censusblk_swwake use=attr column=TOTAL_POP color=blues -a because |
This does not work correctly on my Mac. I just cloned and complied it within the past hour. I tested it with the NC census block data. A good place to look is with the TOTAL_POP attribute because it has an area much higher than any others: cat=1319. Checking the histogram equalization box gives unexpected and incorrect results with a multi-color table (check out one of the viridis tables or GRASS bgyr). It seems initially to work with a single color gradient like blues or reds. But even these are incorrect. TOTAL_POP for cat=1319 should be the most intense color but it is not. It looks exactly the same as some other areas like cat=1364. You can try the same equalizations on a raster version of the census block vector area map and it looks correct. |
I see. I think this PR needs some (a lot of?) work. It gets tricky to implement histogram equalization for vector features. BTW, have you tried v.colors map=censusblk_swwake use=attr column=TOTAL_POP color=blues -a
v.colors map=censusblk_swwake use=attr column=TOTAL_POP color=blues -g |
Nope. They don't work (#1432 (comment)). |
@HuidaeCho would you mind to rebase this PR? |
295a8d9
to
9380697
Compare
@neteler Please try it. |
I have tested it again successfully with the following test:
Which edge cases shall be tested? |
Lightness (in HSL)-based color histogram equalization. Calculates probability using feature areas (no cells in vector), but I may not merge it if I fail to fix the following issue.
seems to work,
but
doesn't work.