Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: Python Language Support #2816

Merged
merged 11 commits into from
Nov 9, 2023
Merged

RFC: Python Language Support #2816

merged 11 commits into from
Nov 9, 2023

Conversation

petrasovaa
Copy link
Contributor

@petrasovaa petrasovaa added the RFC Request For Comment (RFC) document label Feb 9, 2023
@nilason
Copy link
Contributor

nilason commented Feb 9, 2023

I see you are having some struggle with linting.
Maybe you could try pre-commit, see

https://github.com/OSGeo/grass/blob/6b2e3099d67f60e187458c393f0c99d5db57af87/doc/development/submitting/submitting.md#use-pre-commit

from #2797

@petrasovaa
Copy link
Contributor Author

I see you are having some struggle with linting. Maybe you could try pre-commit, see

https://github.com/OSGeo/grass/blob/6b2e3099d67f60e187458c393f0c99d5db57af87/doc/development/submitting/submitting.md#use-pre-commit

from #2797

I knew you were going to suggest this:)
I promise I'll use it next time.

@nilason
Copy link
Contributor

nilason commented Feb 28, 2023

@petrasovaa Do you mind if I push a 80-col hard wrap change commit on these three RFC PRs. As it stands they are very difficult to read as pure text-files without soft-wrap.

@nilason
Copy link
Contributor

nilason commented Mar 1, 2023

I added 80-col line break to this PR, #2813 and #2815.

wenzeslaus
wenzeslaus requested changes May 17, 2023
View reviewed changes
Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. No need to mention GRASS minor version increase for addons, does not add any info and makes the sentence difficult to read.

  2. Typo in version number in the example. Context of the first paragraph implies that we are not using version after the end of life.

doc/development/rfc/python_language_support.md Outdated Show resolved Hide resolved
@petrasovaa @wenzeslaus
Update from review
5282f11 
Co-authored-by: Vaclav Petras <[email protected]>
@wenzeslaus wenzeslaus added this to the 8.4.0 milestone May 17, 2023
@petrasovaa petrasovaa merged commit 4744671 into OSGeo:main Nov 9, 2023
16 checks passed
@petrasovaa petrasovaa deleted the rfc-python-support branch November 9, 2023 00:26
HuidaeCho pushed a commit to HuidaeCho/grass that referenced this pull request Jan 9, 2024
@petrasovaa @neteler
@veroandreo @landam @nilason @wenzeslaus @HuidaeCho
RFC: Python Language Support (OSGeo#2816)
a97a6e9 
Motion passed email: https://lists.osgeo.org/pipermail/grass-psc/2023-June/002726.html

---------

Co-authored-by: Markus Neteler <[email protected]>
Co-authored-by: Veronica Andreo <[email protected]>
Co-authored-by: Martin Landa <[email protected]>
Co-authored-by: Nicklas Larsson <[email protected]>
Co-authored-by: Vaclav Petras <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veroandreo veroandreo veroandreo left review comments

@nilason nilason nilason left review comments

@landam landam landam approved these changes

@wenzeslaus wenzeslaus wenzeslaus approved these changes

@neteler neteler neteler approved these changes

Assignees
No one assigned
Labels
RFC Request For Comment (RFC) document
Projects
None yet
Milestone
8.4.0
Development

Successfully merging this pull request may close these issues.
6 participants
@petrasovaa @nilason @neteler @wenzeslaus @landam @veroandreo