Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wxGUI/psmap: fix vector map properties dialog correct typing the name of the vector map #3087

Merged

Conversation

tmszi
Copy link
Member

@tmszi tmszi commented Jul 15, 2023

Describe the bug
Typing the name of the vector map by keyboard inside vector map properties dialog (Map TextCtrl widget) print error message.

To Reproduce
Steps to reproduce the behavior:

  1. Launch Cartographic composer GUI g.gui.psmap
  2. Add map frame with some raster map e.g. elevation
  3. Add vector map layer by typing vector map name by keyboards e.g. streams
  4. See error
Traceback (most recent call last):
  File "/usr/lib64/grass84/gui/wxpython/psmap/dialogs.py",
line 1865, in OnVector

topoInfo = grass.vector_info_topo(map=vmap)
  File
"/usr/lib64/grass84/etc/python/grass/script/vector.py", line
185, in vector_info_topo

s = read_command("v.info", flags="t", layer=layer, map=map,
env=env)
  File "/usr/lib64/grass84/etc/python/grass/script/core.py",
line 533, in read_command

return handle_errors(returncode, stdout, args, kwargs)
  File "/usr/lib64/grass84/etc/python/grass/script/core.py",
line 345, in handle_errors

raise CalledModuleError(module=module, code=code,
returncode=returncode)
grass.exceptions
.
CalledModuleError
:
Module run `v.info -t layer=1 map=s` ended with an error.
The subprocess ended with a non-zero return code: 1. See
errors above the traceback or in the error output.

and inside GRASS GIS session emulator terminal is printed error message too:

GRASS_INFO_ERROR(17890,1): Vector map <s> not found
GRASS_INFO_END(17890,1)

GRASS_INFO_ERROR(17891,1): Vector map <st> not found
GRASS_INFO_END(17891,1)

GRASS_INFO_ERROR(17892,1): Vector map <str> not found
GRASS_INFO_END(17892,1)

GRASS_INFO_ERROR(17893,1): Vector map <stre> not found
GRASS_INFO_END(17893,1)

GRASS_INFO_ERROR(17894,1): Vector map <strea> not found
GRASS_INFO_END(17894,1)

GRASS_INFO_ERROR(17895,1): Vector map <stream> not found
GRASS_INFO_END(17895,1)

Expected behavior
Typing the name of the vector map by keyboard inside vector map properties dialog (Map TextCtrl widget) should not print error messages.

System description (please complete the following information):

  • Operating System: all
  • GRASS GIS version: all

@tmszi tmszi added bug Something isn't working GUI wxGUI related backport to 8.3 labels Jul 15, 2023
@tmszi tmszi added this to the 8.4.0 milestone Jul 15, 2023
@tmszi tmszi merged commit ad3b2d1 into OSGeo:main Sep 18, 2023
tmszi added a commit to tmszi/grass that referenced this pull request Sep 18, 2023
… of the vector map (OSGeo#3087)

* Use gs.find_file() func instead of pygrass module
tmszi added a commit to tmszi/grass that referenced this pull request Sep 18, 2023
… of the vector map (OSGeo#3087)

* Use gs.find_file() func instead of pygrass module
@tmszi tmszi deleted the wxgui-psmap-vprops-dialog-fix-type-input-vector-map branch September 18, 2023 17:40
landam pushed a commit to landam/grass that referenced this pull request Oct 25, 2023
… of the vector map (OSGeo#3087)

* Use gs.find_file() func instead of pygrass module
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
… of the vector map (OSGeo#3087)

* Use gs.find_file() func instead of pygrass module
HuidaeCho pushed a commit to HuidaeCho/grass that referenced this pull request Jan 9, 2024
… of the vector map (OSGeo#3087)

* Use gs.find_file() func instead of pygrass module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working GUI wxGUI related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants