Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: CITATION.cff with licence entry SPDX compliant #3115

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

neteler
Copy link
Member

@neteler neteler commented Aug 8, 2023

@neteler neteler added bug Something isn't working backport to 8.3 backport to 7.8 PR needs to be backported to release branch 7.8 labels Aug 8, 2023
@neteler neteler self-assigned this Aug 8, 2023
Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. The new code is correct according to the Citation File Format documentation:

license...description: The SPDX license identifier(s) for the license...

And the value checks even against CFF's license-enum.

Given that the other branches just work, I hope that this fixes the Zenodo issue, too.

@wenzeslaus
Copy link
Member

...other branches just work...

Correction: That would be 7.8 only because that's the only one with recent release. No backport is needed there. We are using the automated Zenodo metadata extraction there.

@neteler neteler merged commit ead8e8d into OSGeo:main Aug 8, 2023
19 checks passed
@neteler neteler deleted the CITATION_cff_license_spdx_conform branch August 8, 2023 16:18
@neteler neteler removed the backport to 7.8 PR needs to be backported to release branch 7.8 label Aug 8, 2023
@neteler neteler changed the title CITATION.cff: make license entry SPDX conform docs: CITATION.cff with licence entry SPDX compliant Aug 8, 2023
@neteler
Copy link
Member Author

neteler commented Aug 8, 2023

In fact, we do not have the CITATION.cff file in GRASS GIS 7.

@neteler neteler added this to the 8.2.2 milestone Aug 8, 2023
landam pushed a commit to landam/grass that referenced this pull request Oct 25, 2023
neteler added a commit to nilason/grass that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants