-
-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
win: Remove libexpat-1.dll from package.sh #3479
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is the same changes as the original PR. I assume that since you had the need to recreate it for the correct branch, that it was implicitly approved by you originally. (I was good with the previous one, but didn't know if there would be unforeseen problems with it). So I'm approving and merging to follow explicitly the branch restrictions in place.
I'm not merging yet: Would you want to add a co-authored by tag in the squash merge message to attribute it to the original author too? |
There should definitely be added the co-authored by tag for @jef-n . |
Ok but then we could simply merge #3476, right?
I also don't know why @landam didn't simply switch it to "main". |
Co-authored-by: Jürgen Fischer <[email protected]>
Backported by cherry-picking to G83 in b076b0c |
This PR replaces #3476 (base branch changed from
releasebranch_8_3
tomain
)