wxGUI/history: Add time/status icons in front of browser nodes #3679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great! Could we have a separate check image (e.g., success.png) only for this? Otherwise this image is used elsewhere in gui and it wouldn't visually fit with the rest of the icons. |
added 3 commits
May 3, 2024 16:56
lindakarlovska
force-pushed
the
wxGUI-history-icons
branch
from
73f547c
to
0b538ea
Compare
lindakarlovska
force-pushed
the
wxGUI-history-icons
branch
from
0b538ea
to
fdabb8e
Compare
petrasovaa
reviewed
May 3, 2024
petrasovaa
reviewed
May 3, 2024
petrasovaa
reviewed
May 3, 2024
petrasovaa
reviewed
May 3, 2024
petrasovaa
reviewed
May 6, 2024
added 2 commits
May 7, 2024 15:06
lindakarlovska
force-pushed
the
wxGUI-history-icons
branch
from
f9e4dc0
to
b0f5be6
Compare
lindakarlovska
force-pushed
the
wxGUI-history-icons
branch
from
b0f5be6
to
8415332
Compare
petrasovaa
reviewed
May 7, 2024
petrasovaa
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is built on #3622 (has to be rebased after #3622 will be merged). It adds icons in front of each node in the history browser panel.
Command nodes are distinguished according to command status:
failed :
aborted:
running:
success:
unknown:
All time period nodes have the same icon:
The history browser looks as follows (with #3622 applied):
