-
-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib/gmath: properly guard BLAS and LAPACK dependent code #4346
Conversation
This reverts commit cefdbef.
I used Mac runner to test without |
Side-question concerning addons: In my fork I get
Would that be addressed here as well? |
OSGeo/grass-addons#1206 adds liblapacke-dev which is enough. |
This reverts commit 02b0d96.
856956e
to
2cfa7a3
Compare
2cfa7a3
to
0578d1f
Compare
I have now updated this to work as it did before d5bb442. Namely, to only compile lib/gmath/la.c (and being able to include la.h) IFF compiled with BLAS and LAPACK. The first solution (02b0d96) made available all parts which weren't directly using BLAS or LAPACK (only a couple of functions out of 30+) even without compiling with BLAS and LAPACK. I'd say we follow the original logic and go for the present state of this PR. If need arises in the future, we may revise this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like a straightforward solution.
Properly guard BLAS and LAPACK dependent code.