wxGUI: Refactored try-except block to be more robust in dialogs.py #4383
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is more of a suggestion since I thought this would be a better way to handle this instead of a
try-except
block. It modifies theGetSQLString
method in theDisplayAttributesDialog
class to improve how it retrieves values from widgets. The changes make the code more robust and explicit in handling different widget types.Changes
except
clause with explicit checks forGetValue()
andGetLabel()
methodsReason for Changes
The original code used a bare
except
clause to handle potentialAttributeError
s when trying to callGetValue()
orGetLabel()
on widgets. This approach was not robust and could potentially hide unexpected errors. The new implementation explicitly checks for the presence of these methods and raises anAttributeError
if neither are present.