Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fixed E265 from image2target/ #4399

Merged
merged 4 commits into from
Sep 28, 2024
Merged

Conversation

arohanajit
Copy link
Contributor

Just removed extra # which fixed all E265 from image2target/

@github-actions github-actions bot added GUI wxGUI related Python Related code is in Python labels Sep 27, 2024
@arohanajit arohanajit changed the title checks: fixed E265 from image2target/ docs: fixed E265 from image2target/ Sep 27, 2024
@echoix
Copy link
Member

echoix commented Sep 27, 2024

Did the double # prevent them to be recognized by the parser before? These are what is used to generate the interface, the docs, and validate the arguments given to a module

@arohanajit
Copy link
Contributor Author

Yeah, I think its coded to look for # at start hence it generates an error for anything else. I thought that should be fine since its pretty much in line with format of all other docs i've seen in other files till now.

@petrasovaa
Copy link
Contributor

Did the double # prevent them to be recognized by the parser before? These are what is used to generate the interface, the docs, and validate the arguments given to a module

Yes, it was not working, but in the current code, the parser part is commented out anyway. @arohanajit I suggest to remove that part instead of fixing it.

@arohanajit
Copy link
Contributor Author

arohanajit commented Sep 27, 2024

I've removed the parser code. Could you please have a quick look at it? That's a lot of lines removed and I want to make sure I've not removed anything that might be reqd in future

@echoix
Copy link
Member

echoix commented Sep 27, 2024

Looks fine, don't worry. It doesn't look like you removed something that was used

@echoix echoix merged commit 4f689fe into OSGeo:main Sep 28, 2024
26 checks passed
@echoix echoix added this to the 8.5.0 milestone Sep 28, 2024
@arohanajit arohanajit deleted the image2target-e265 branch September 30, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI wxGUI related Python Related code is in Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants