Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r3.in.v5d, r3.out.v5d: Deprecate CRAY HW specific code #4545

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

ymdatta
Copy link
Contributor

@ymdatta ymdatta commented Oct 17, 2024

Currently, there is no sign either from github issues or grass dev archive that many people are using CRAY code which was introduced 25 years ago. As part of fixing a bug, we found that it was hard to find reference materials related to CRAY, due to it being old and not in usage anymore. For this reason, deprecate CRAY code and corresponding complexity that comes with it.

Currently, there is no sign either from github issues or
grass dev archive that many people are using CRAY code which
was introduced 25 years ago. As part of fixing a bug, we found
that it was hard to find reference materials related to CRAY,
due to it being old and not in usage anymore. For this reason,
deprecate CRAY code and corresponding complexity that comes
with it.

Signed-off-by: Mohan Yelugoti <[email protected]>
@github-actions github-actions bot added C Related code is in C module raster3d labels Oct 18, 2024
Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was more difficult to review then I expected from a code removal change. I think there is one issue, but otherwise it's good.

raster3d/r3.out.v5d/binio.c Show resolved Hide resolved
@wenzeslaus wenzeslaus enabled auto-merge (squash) November 8, 2024 21:39
@wenzeslaus wenzeslaus merged commit 8dced26 into OSGeo:main Nov 8, 2024
26 checks passed
@github-actions github-actions bot added this to the 8.5.0 milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C Related code is in C module raster3d
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants