Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow idea props to be accessed by generators #10

Merged
merged 1 commit into from
Jun 10, 2024
Merged

allow idea props to be accessed by generators #10

merged 1 commit into from
Jun 10, 2024

Conversation

cjzamora
Copy link
Contributor

@cjzamora cjzamora commented Jun 10, 2024 •
edited by cblanquera
Loading

What is this PR for?

  • Just updating content and/or documentation
  • This fixes issue #_____
  • Spot fix (no issue #)
  • Merging WIP feature #_____
  • Merging done feature Open Prop for generators to access #11
  • This is a merge from a version branch
  • Adding/Updating tests
  • This is a conflict resolution
  • This is a branch cleanup
  • Other: ________________

I verify that...

  • I have logged my time in the commits
  • I have logged my time in this PR
  • I have tagged all the relevant issues
  • I am using VS Code for type checks and linting, or
  • I have ran npm run test with no errors
  • I have manually checked that this bug or feature is working

@cblanquera
Copy link
Collaborator

Auto comment failed due to no fault of your own. The problem is actually mentioned on GitHub's secrets page:

Secrets are not passed to workflows that are triggered by a pull request from a fork. Learn more.

The "Learn more" links to this page that doesn't provide more information but repeats the message:
https://help.github.com/actions/automating-your-workflow-with-github-actions/creating-and-using-encrypted-secrets

@cblanquera cblanquera merged commit 1fcd828 into OSSPhilippines:main Jun 10, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjzamora @cblanquera