Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

なろうServiceのリファクタリング #24

Merged
merged 18 commits into from
Apr 2, 2024
Merged

Conversation

miyaji255
Copy link

No description provided.

@miyaji255 miyaji255 marked this pull request as ready for review March 16, 2024 13:41
@miyaji255 miyaji255 requested a review from TakenPt March 31, 2024 03:31
Copy link

@aiueo-1234 aiueo-1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

どこかのタイミングでMainViewModel.csの157行目を "https://ncode.syosetu.com" に変更しておいてほしいです

Epub/KoeBook.Epub/Services/ScrapingNaroService.cs Outdated Show resolved Hide resolved
Epub/KoeBook.Epub/Services/ScrapingNaroService.cs Outdated Show resolved Hide resolved
Epub/KoeBook.Epub/Services/ScrapingNaroService.cs Outdated Show resolved Hide resolved
Copy link

@TakenPt TakenPt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

document.Chapters.Add() を行う時には、 chapterTitleの更新が必要です。
ReadPageAsync() 内で、chapterTitle を取得する際の連載の場合と短編の場合との処理が逆です。

Epub/KoeBook.Epub/Services/ScrapingNaroService.cs Outdated Show resolved Hide resolved
aiueo-1234
aiueo-1234 previously approved these changes Apr 1, 2024
Copy link

@aiueo-1234 aiueo-1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miyaji255 miyaji255 requested a review from TakenPt April 1, 2024 06:20
@miyaji255 miyaji255 merged commit 78e58aa into main Apr 2, 2024
2 checks passed
@miyaji255 miyaji255 deleted the feat/#1-2-naro branch April 2, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants