Feat/#51 #52
Merged
Feat/#51 #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miyaji255
reviewed
May 2, 2024
miyaji255
reviewed
May 2, 2024
Comment on lines
26
to
28
| var ms = new MemoryStream(); | ||
| ms.Write(wavData); | ||
| ms.Position = 0; |
There was a problem hiding this comment.
usingつけておいてください。
また、コンストラクタでbyte[]が指定できたと思います。
miyaji255
reviewed
May 2, 2024
miyaji255
reviewed
May 2, 2024
|
レビューが遅れてしまいすみません。簡単に修正できるポイントだけコメントしました。結合した音声がうまく再生できていることは確認できましたか？ |
|
統合した音声を使って作られたepubがdiscordに上がっています。その音声を聞く限り音声統合はうまく行っていると思います |
|
了解しました。修正はできそうですか？忙しいならこちらで修正します |
今から修正します |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TaPetさんのパソコンで作業していたのでコミットがTaPetさんになっていますが、作業者は自分です