Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ToHmdMatrix34_t and ToMatrix4x4 methods do not properly transpose their matrices.
Dotnet uses row vectors, whereas ovr uses column vectors. This requires the entire Matrix to be transposed, but the current methods only transpose the last row/column (the translation component).
This isn't noticeable as long as scaling is uniform and rotation only happens along one axis, but does not allow for more complex affine transformations.
This pull request fixes this. However, this is a breaking change, since rotations now happen the other (correct) way around.