Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributors to users #2917

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

krrish-sehgal
Copy link
Contributor

@krrish-sehgal krrish-sehgal commented Nov 13, 2024

Fixes #2884.

Changes:
"Users" now default shows contributors unless the other tag is selected
contributors are always loaded from json
other tags are loaded by flitering from profile section
"Contributors" option loads users/tag=contributors page
contributor_view changed to contributor_detail_view for the More info option on contributor page
the card for all contributors and other tags is synced in their design.

Screen.Recording.2024-11-13.at.2.17.12.PM.mov

@krrish-sehgal
Copy link
Contributor Author

@DonnieBLT this PR could close #2884, could you please give it a review?

Copy link
Collaborator

@DonnieBLT DonnieBLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean for these contributors to be linked to users on the site. Can you map each user to the contributor?

@krrish-sehgal
Copy link
Contributor Author

okay that will require me to personally contact the contributors and get their blt usernames as there is no direct way to map hard coded contributor names to their blt user profiles , however is the UI meets what you had in mind? like when on the users page , the name of the user i clicked , the user profile of that contributor will get opened

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate all the contributors to users and make the page work based on a tag
2 participants