Port a Brakeman update to content_tag for Rails 6 #1552
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR: presidentbeef/brakeman#1778
It was pointed out that content_tag's attributes will no longer output unescaped html in the first attribute, which I understand to be the cause of this warning in this guide. Content_tag therefore should no longer be warned against since Rails 6.1.7.3 unless I have misunderstood the underlying complaint.
Edit: Also worth mentioning at the current time, Rails 6.1.7.3 is out of support so it, and older versions, should no longer be in use. Only Rails 7.0 and above are still within their EOL.
You're A Rockstar
Thank you for submitting a Pull Request (PR) to the Cheat Sheet Series.
Please make sure that for your contribution:
[TEXT](URL)
If your PR is related to an issue, please finish your PR text with the following line:
This PR fixes issue #
<REPLACE WITH ISSUE NUMBER>
.Thank you again for your contribution 😃