Refactor SSL socket handling to use wrap_socket_to_ssl method
#980
+16
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return socket_connection, ssl_flag | ||
| def wrap_socket_to_ssl(socket_connection): | ||
| context = ssl.SSLContext() | ||
| return context.wrap_socket(socket_connection) |
Check failure
Code scanning / CodeQL
Use of insecure SSL/TLS version High
tanaydin
force-pushed
the
fix-for-ssl-wrap-socket-py312
branch
6 times, most recently
from
b54be42 to
93848a5
Compare
Update `test_ssl.py`, `socket.py`, and `ssl.py` to replace direct calls to `ssl.wrap_socket` with a new `wrap_socket_to_ssl` function. Adjust test cases accordingly to ensure proper integration and functionality. This improves code organization and makes SSL socket wrapping more explicit.Refactor SSL socket wrapping logic Moved SSL socket wrapping to a dedicated function `wrap_socket_to_ssl` within the `ssl.py` module, improving code modularity and readability. Updated the imports and references across the codebase to reflect this change, enhancing maintainability and reducing redundancy.
tanaydin
force-pushed
the
fix-for-ssl-wrap-socket-py312
branch
from
93848a5 to
e0ef65e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
test_ssl.py,socket.py, andssl.pyto replace direct calls tossl.wrap_socketwith a newwrap_socket_to_sslfunction. Adjust test cases accordingly to ensure proper integration and functionality. This improves code organization and makes SSL socket wrapping more explicit.Refactor SSL socket wrapping logicMoved SSL socket wrapping to a dedicated function
wrap_socket_to_sslwithin thessl.pymodule, improving code modularity and readability. Updated the imports and references across the codebase to reflect this change, enhancing maintainability and reducing redundancy.Proposed change
Your PR description goes here.
Type of change
Checklist
make pre-commit, it didn't generate any changesmake test, all tests passed locally