Dev #4
Merged
Dev #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Created initial project styling settings * Authorization Working * IT LIVES * Added Refresh * Updated Refreshing Tokens * Removed unused method * Created new path alias for Effects folder * Added axios * Deleted endpoint methods * Moved Spotify Song Request to a custom Firebot Effect * Added outputs to Effect * Some tweaks on refreshing, currently not working * "Fixed" things maybe * really fixed it for real this time * Undid connectionToggle false * nvm * Moved vars off this * Working version * No minimize * Ok it works fr fr * Removed a *lot* like a *LOT* * Removed unused stuff * Updated Integration details and optimized imports * Added Dev to Main workflow
* Fixed subsequent refreshes breaking * Removed unnecessary log * Cleaning up * Moved globals to Firebot utils and cleaned up variables * Updated error message in findAndEnqueueTrackAsync * Disallow duplicates * Better duplication error handling * More cleanup * Removed unused package axios * Take into consideration Allow Duplicates option * Remove unnecessary method * Removed router as oauth callback endpoint is no longer needed * Removed unnecessary package lodash * Added Queue Position to track details on enqueue
* Fixed subsequent refreshes breaking * Removed unnecessary log * Cleaning up * Moved globals to Firebot utils and cleaned up variables * Updated error message in findAndEnqueueTrackAsync * Disallow duplicates * Better duplication error handling * More cleanup * Removed unused package axios * Take into consideration Allow Duplicates option * Remove unnecessary method * Removed router as oauth callback endpoint is no longer needed * Removed unnecessary package lodash * Added Queue Position to track details on enqueue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code cleanup