Feature/more playback effects #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oceanity
added a commit
that referenced
this pull request
Jun 1, 2024
* Updated Active Device retrieval and added playback state change effect * Removed unused package `open` * Added fallback * Added notes that Spotify Premium is required, and moved some duplicate code to helper functions * More cleanup * Added ChangePlaybackVolumeEffect * Added changePlaybackVolume effect and some renames/copy changes * Moved integrationId to export var on main, small tweaks * Renamed some stuff * Added Change Repeat State Effect * Moved a TON of stuff to a more reasonable class structure 😰 * Moved remaining functions to new class structure * Changed integration Id to fixed string because it was returning undefined randomly * Changed integration Id to fixed string because it was returning undefined randomly * Fixed typo * Minor copy changes * Added GetCurrentlyPlayingtrackEffect and made small tweaks * Feature/more playback effects (#8) * Added memoization to Active Device Id * Added Seek to Position Effect * Fixed that infinite recursion 😰 * Fixed allow duplicates * Add replaceVariableManager * Change casing on Effect definitions * Replaced GetCurrentlyPlayingTrack effect with some replace variables * Added Memoization to replace variables to cut back on requests * Updated Readme * Created Track Changed Event * Made callback URL code text to avoid auto linking * Fixed missing step * Added confirmed step * Created lists for Events and ReplaceVariables to move imports off spotifyIntegration * Merge issues resolved
Oceanity
added a commit
that referenced
this pull request
Jun 1, 2024
* Updated Active Device retrieval and added playback state change effect * Removed unused package `open` * Added fallback * Added notes that Spotify Premium is required, and moved some duplicate code to helper functions * More cleanup * Added ChangePlaybackVolumeEffect * Added changePlaybackVolume effect and some renames/copy changes * Moved integrationId to export var on main, small tweaks * Renamed some stuff * Added Change Repeat State Effect * Moved a TON of stuff to a more reasonable class structure 😰 * Moved remaining functions to new class structure * Changed integration Id to fixed string because it was returning undefined randomly * Changed integration Id to fixed string because it was returning undefined randomly * Fixed typo * Minor copy changes * Added GetCurrentlyPlayingtrackEffect and made small tweaks * Feature/more playback effects (#8) * Added memoization to Active Device Id * Added Seek to Position Effect * Fixed that infinite recursion 😰 * Fixed allow duplicates * Add replaceVariableManager * Change casing on Effect definitions * Replaced GetCurrentlyPlayingTrack effect with some replace variables * Added Memoization to replace variables to cut back on requests * Updated Readme * Created Track Changed Event * Made callback URL code text to avoid auto linking * Fixed missing step * Added confirmed step * Created lists for Events and ReplaceVariables to move imports off spotifyIntegration * Merge issues resolved * Feature/updated readme (#10) * Updated readme * Removed file that should have been deleted * rearranged variables * Add another step to Setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.