Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev -> Main: 0.7.5 #80

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Dev -> Main: 0.7.5 #80

merged 1 commit into from
Aug 9, 2024

Conversation

Oceanity
Copy link
Owner

@Oceanity Oceanity commented Aug 9, 2024

What's Changed

Fixes

  • Plugin will no longer Chat Feed Alert on errors
  • No more errors when Non-Premium user uses plugin due to Queue pulls

Removed Variables

  • $spotifyTrackTitle
  • $spotifyTrackArtist
  • $spotifyTrackArtists
    • you were warned :P
    • more variables have been marked for deletion, if you see warnings in chat feed alerts, you should fix them

Removed Events

  • Queue Changed
    • Honestly very unfortunate this needs to be regressed, but, blame Spotify having a weird Premium-only limitation on Get Spotify Queue in their API /shrug

Changed Variables

  • $spotifyQueue
  • $rawSpotifyQueue
    • Due to the fact these need premium, they now pull every time they use the variable with auth, so I'd advise folks to save these to a custom variable and pull data from that to avoid rate limits

Behind the Scenes

  • Moved some helper functions to a new shared library, @oceanity/firebot-helpers, this shouldn't have any functional effect on the plugin but means I can be lazier in my others

@Oceanity
Feature/move helpers to lib + fixes (#79)
0426672 
* Fixed up menu position and some styles on input fields

* Updated changelogs and bumped version

* Moved some Non-Spotify related helper functions to new npm library, converted copy-build to ts just because

* Updated oceanity/firebot-helpers dependency

* Moved DbService to helper library, converted use of Db in lyrics to fs-extra because it's just raw saving/loading entire json files

* Removed live queue updating, removed announced deprecated variables, deprecated more variables

* Moved calls to firebot utils to @oceanity/firebot-helpers

* Updated mock

* Moved more methods to @oceanity/firebot-helpers

* Fixed some typos

* Updated queue variables to pull live data

* Updated description

* removed Launch

* updated changelog
@Oceanity Oceanity merged commit 341e486 into main Aug 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Oceanity