[3/3] - Replace Legacy History Commitment Implementation #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the new history commitment impl across codebase.
TODO: Stop padding last hashes in the testing/l2-state-provider mock
NOTE: The remaining tests seem to fail when posting a block challenge root edge, because of an inclusion proof verification failing. This is because the inclusion proof for the last leaf of a history commitment is only computed if the virtual size is a power of two, but our layer zero edge sizes are 2^26 + 1, 2^20 + 1, and 2^22 + 1, respectively which are not powers of two :(. Need to figure out how we can address this, or choose layer zero edge sizes that are powers of two