Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recordingdb: add config, trie flush, and metrics #240

Merged
merged 2 commits into from
Jul 10, 2023
Merged

recordingdb: add config, trie flush, and metrics #240

merged 2 commits into from
Jul 10, 2023

Conversation

tsahee
Copy link
Contributor

@tsahee tsahee commented Jul 7, 2023

No description provided.

@cla-bot cla-bot bot added the s CLA signed label Jul 7, 2023
@tsahee tsahee mentioned this pull request Jul 7, 2023
Merged
PlasmaPower
PlasmaPower reviewed Jul 8, 2023
View reviewed changes
Copy link
Collaborator

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's not merge this until everything else is ready because this is a breaking API change for nitro

PlasmaPower
PlasmaPower approved these changes Jul 10, 2023
View reviewed changes
Copy link
Collaborator

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower PlasmaPower merged commit 3725b60 into master Jul 10, 2023
@PlasmaPower PlasmaPower deleted the recordingdb_features branch July 10, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PlasmaPower PlasmaPower PlasmaPower approved these changes

Assignees
No one assigned
Labels
s CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsahee @PlasmaPower