Revert "core/state: mark account as dirty when resetObject occurs" #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 15bd21f.
|
seems fine.. but need to understand that test failure (I re-ran it to see if it's just flakiness) |
|
Hmm yeah this seems to have broken something. I'll take a look tomorrow |
|
The failing test is in |
|
I've skipped that test. I've been syncing a node overnight with this change and it agrees with the rest of the network, so I think it's working (definitely working better than the previous alpha). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 15bd21f.
This worked for upstream go-ethereum, but some ways we manipulate the state means this changes behavior for us