Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix balance burn error message #298

Closed
wants to merge 1 commit into from
Closed

Fix balance burn error message #298

wants to merge 1 commit into from

Conversation

rachel-bousfield
Copy link
Contributor

This PR fixes a balance burn error message

@cla-bot cla-bot bot added the s CLA signed label Mar 28, 2024
joshuacolvin0
joshuacolvin0 approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rachel-bousfield
Copy link
Contributor Author

Closing since opSelfdestruct6780 now records a burn equal to the amount in the account due to the new SubBalance line. The previous behavior should be correct.

@rachel-bousfield rachel-bousfield deleted the fix-balance-burn branch March 28, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuacolvin0 joshuacolvin0 joshuacolvin0 approved these changes

Assignees
No one assigned
Labels
s CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rachel-bousfield @joshuacolvin0