Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge v1.13.11 #311

Merged
merged 45 commits into from
Apr 30, 2024
Merged

Merge v1.13.11 #311

merged 45 commits into from
Apr 30, 2024

Commits on Jan 11, 2024

  1. Configuration menu
    Copy the full SHA
    2e8b118 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2024

  1. docs: fix badge in README (#28796)

    * Fix broken badge in README.md
    
    Replaced broken Github link with IPFS link for long-term storage.
    
    * update go badge
    
    Co-authored-by: lightclient <[email protected]>
    
    ---------
    
    Co-authored-by: lightclient <[email protected]>
    drstevenbrule and lightclient authored Jan 12, 2024
    Configuration menu
    Copy the full SHA
    5c2de7f View commit details
    Browse the repository at this point in the history
  2. eth: minor change of config-accessor (#28782)

    eth: refactor `GetVM`
    0xmountaintop authored Jan 12, 2024
    Configuration menu
    Copy the full SHA
    6e235c0 View commit details
    Browse the repository at this point in the history
  3. cmd: fix typos (#28798)

    vuittont60 authored Jan 12, 2024
    Configuration menu
    Copy the full SHA
    ae4ea04 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7280a5b View commit details
    Browse the repository at this point in the history
  5. accounts, ethclient: minor tweaks on the new simulated backend (#28799)

    * accounts, ethclient: minor tweaks on the new simulated backend
    
    * ethclient/simulated: add an initial batch of gas options
    
    * accounts, ethclient: remove mandatory gasLimit constructor param
    
    * accounts, ethclient: minor option naming tweaks
    karalabe authored Jan 12, 2024
    Configuration menu
    Copy the full SHA
    065f82a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    43ba7d6 View commit details
    Browse the repository at this point in the history
  7. cmd/devp2p/internal/ethtest: skip large tx test on github build (#28794)

    This test was failling consistently on the github 32-bit build probably due to slow IO. Skipping it for that green check.
    s1na authored Jan 12, 2024
    Configuration menu
    Copy the full SHA
    a608c0a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    1335ba5 View commit details
    Browse the repository at this point in the history
  9. internal/ethapi: avoid using pending for defaults (#28784)

    Given the discussions around deprecating pending (see #28623 or ethereum/execution-apis#495), we can move away from using the pending block internally, and use latest instead
    s1na authored Jan 12, 2024
    Configuration menu
    Copy the full SHA
    407f779 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2024

  1. Configuration menu
    Copy the full SHA
    29b7355 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1485814 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2024

  1. tests: update reference tests (#28778)

    Updates the reference tests to the latest version
    holiman authored Jan 15, 2024
    Configuration menu
    Copy the full SHA
    89ccc68 View commit details
    Browse the repository at this point in the history
  2. ethclient: add tests for TransactionInBlock (#28283)

    Co-authored-by: Felix Lange <[email protected]>
    hyunchel and fjl authored Jan 15, 2024
    Configuration menu
    Copy the full SHA
    7596db5 View commit details
    Browse the repository at this point in the history
  3. eth: fix potential hang in waitSnapExtension (#28744)

    This should fix a rare hang in waitSnapExtension during shutdown.
    niuxiaojie81 authored Jan 15, 2024
    Configuration menu
    Copy the full SHA
    18e154e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9ee6809 View commit details
    Browse the repository at this point in the history
  5. acounts/usbwallet: fix typo (#28815)

    acounts:fix typo
    bodhi-crypo authored Jan 15, 2024
    Configuration menu
    Copy the full SHA
    566754c View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. Configuration menu
    Copy the full SHA
    d4f25b4 View commit details
    Browse the repository at this point in the history
  2. tracer: use proper base fee in tests (#28775)

     In the tracing tests, the base fee was generally set to nil. This commit changes this to pass the proper base instead, and fixes the few tests which become broken by the change.
    palango authored Jan 16, 2024
    Configuration menu
    Copy the full SHA
    c66ca8b View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. Configuration menu
    Copy the full SHA
    2e2e89c View commit details
    Browse the repository at this point in the history
  2. internal/ethapi: handle blobs in API methods (#28786)

    EIP-4844 adds a new transaction type for blobs. Users can submit such transactions via `eth_sendRawTransaction`. In this PR we refrain from adding support to `eth_sendTransaction` and in fact it will fail if the user passes in a blob hash.
    
    However since the chain can handle such transactions it makes sense to allow simulating them. E.g. an L2 operator should be able to simulate submitting a rollup blob and updating the L2 state. Most methods that take in a transaction object should recognize blobs. The change boils down to adding `blobVersionedHashes` and `maxFeePerBlobGas` to `TransactionArgs`. In summary:
    
    - `eth_sendTransaction`: will fail for blob txes
    - `eth_signTransaction`: will fail for blob txes
    
    The methods that sign txes does not, as of this PR, add support the for new EIP-4844 transaction types. Resuming the summary:
    
    - `eth_sendRawTransaction`: can send blob txes
    - `eth_fillTransaction`: will fill in a blob tx. Note: here we simply fill in normal transaction fields + possibly `maxFeePerBlobGas` when blobs are present. One can imagine a more elaborate set-up where users can submit blobs themselves and we fill in proofs and commitments and such. Left for future PRs if desired.
    - `eth_call`: can simulate blob messages
    - `eth_estimateGas`: blobs have no effect here. They have a separate unit of gas which is not tunable in the transaction.
    s1na authored Jan 17, 2024
    Configuration menu
    Copy the full SHA
    e5d5e09 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. Configuration menu
    Copy the full SHA
    830f3c7 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. crypto/kzg4844: add helpers for versioned blob hashes (#28827)

    The code to compute a versioned hash was duplicated a couple times, and also had a small
    issue: if we ever change params.BlobTxHashVersion, it will most likely also cause changes
    to the actual hash computation. So it's a bit useless to have this constant in params.
    fjl authored Jan 19, 2024
    Configuration menu
    Copy the full SHA
    0e93da3 View commit details
    Browse the repository at this point in the history
  2. ethclient: apply accessList field in toCallArg (#28832)

    Co-authored-by: Felix Lange <[email protected]>
    colinlyguo and fjl authored Jan 19, 2024
    Configuration menu
    Copy the full SHA
    1c48829 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2024

  1. params, core/forkid: enable cancun on sepolia and holesky (#28834)

    This change enables Cancun 
    
    - Sepolia at 1706655072 (Jan 31st, 2024)
    - Holesky at 1707305664 (Feb 7th, 2024)
    
    Specification: ethereum/execution-specs#860
    MariusVanDerWijden authored Jan 20, 2024
    Configuration menu
    Copy the full SHA
    f55a10b View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. core, core/rawdb, eth/sync: no tx indexing during snap sync (#28703)

    This change simplifies the logic for indexing transactions and enhances the UX when transaction is not found by returning more information to users.
    
    Transaction indexing is now considered as a part of the initial sync, and `eth.syncing` will thus be `true` if transaction indexing is not yet finished. API consumers can use the syncing status to determine if the node is ready to serve users.
    rjl493456442 authored Jan 22, 2024
    Configuration menu
    Copy the full SHA
    78a3c32 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. Configuration menu
    Copy the full SHA
    6a724b9 View commit details
    Browse the repository at this point in the history
  2. go.{mod,sum}: upgrade go-ole to support arm64 (#28859)

    go.{mod,sum}: upgrade go-ole
    gballet authored Jan 23, 2024
    Configuration menu
    Copy the full SHA
    19d9977 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    819a497 View commit details
    Browse the repository at this point in the history
  4. all: use uint256 in state (#28598)

    This change makes use of uin256 to represent balance in state. It touches primarily upon statedb, stateobject and state processing, trying to avoid changes in transaction pools, core types, rpc and tracers.
    holiman authored Jan 23, 2024
    Configuration menu
    Copy the full SHA
    a5a4fa7 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4c8d92d View commit details
    Browse the repository at this point in the history
  6. core/state/snapshot: use AddHash/ContainHash instead of Hasher interf…

    …ace (#28849)
    
    This change switches from using the `Hasher` interface to add/query the bloomfilter to implementing it as methods.
    This significantly reduces the allocations for Search and Rebloom.
    MariusVanDerWijden authored Jan 23, 2024
    Configuration menu
    Copy the full SHA
    c89a3da View commit details
    Browse the repository at this point in the history
  7. core/vm: fix misleading comment (#28860)

    fix misleading comment
    trocher authored Jan 23, 2024
    Configuration menu
    Copy the full SHA
    2dc7477 View commit details
    Browse the repository at this point in the history
  8. eth/catalyst: add timestamp checks to fcu and new payload and improve…

    … param checks (#28230)
    
     This PR introduces a few changes with respect to payload verification in fcu and new payload requests:
    
    * First of all, it undoes the `verifyPayloadAttributes(..)` simplification I attempted in #27872. 
    * Adds timestamp validation to fcu payload attributes [as required](https://github.com/ethereum/execution-apis/blob/main/src/engine/cancun.md#specification-1) (section 2) by the Engine API spec. 
    * For the new payload methods, I also update the verification of the executable data. For `newPayloadV2`, it does not currently ensure that cancun values are `nil`. Which could make it possible to submit cancun payloads through it. 
    * On `newPayloadV3` the same types of checks are added. All shanghai and cancun related fields in the executable data must be non-nil, with the addition that the timestamp is _only_ with cancun.
    * Finally it updates a newly failing catalyst test to call the correct fcu and new payload methods depending on the fork.
    lightclient authored Jan 23, 2024
    Configuration menu
    Copy the full SHA
    98eaa57 View commit details
    Browse the repository at this point in the history
  9. core/txpool, eth/catalyst: fix racy simulator due to txpool backgroun…

    …d reset (#28837)
    
    This PR fixes an issues in the new simulated backend. The root cause is the fact that the transaction pool has an internal reset operation that runs on a background thread.
    
    When a new transaction is added to the pool via the RPC, the transaction is added to a non-executable queue and will be moved to its final location on a background thread. If the machine is overloaded (or simply due to timing issues), it can happen that the simulated backend will try to produce the next block, whilst the pool has not yet marked the newly added transaction executable. This will cause the block to not contain the transaction. This is an issue because we want determinism from the simulator: add a tx, mine a block. It should be in there.
    
    The PR fixes it by adding a Sync function to the txpool, which waits for the current reset operation (if any) to finish, and then runs an entire round of reset on top. The new round is needed because resets are only triggered by new head events, so newly added transactions will not trigger the outer resets that we can wait on. The transaction pool would eventually internally do a reset even on transaction addition, but there's no easy way to wait on that and there's no meaningful reason to bubble that across everything. A clean outer reset will at worse be a small noop goroutine.
    karalabe authored Jan 23, 2024
    Configuration menu
    Copy the full SHA
    542c861 View commit details
    Browse the repository at this point in the history
  10. core: move tx indexer to its own file (#28857)

    This change moves all the transaction indexing functions to a separate txindexer.go file and defines a txIndexer structure as a refactoring.
    rjl493456442 authored Jan 23, 2024
    Configuration menu
    Copy the full SHA
    6b0de79 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. eth/catalyst: prefix payload id with version (#28246)

    GetPayloadVX should only return payloads which match its version. GetPayloadV2 is a special snowflake that supports v1 and v2 payloads. This change uses a a version-specific prefix within in the payload id, basically a namespace for the version number.
    lightclient authored Jan 24, 2024
    Configuration menu
    Copy the full SHA
    a8a8758 View commit details
    Browse the repository at this point in the history
  2. ethclient: fix flaky test (#28864)

    Fix flaky test due to incomplete transaction indexing
    rjl493456442 authored Jan 24, 2024
    Configuration menu
    Copy the full SHA
    765f290 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    99dc3fe View commit details
    Browse the repository at this point in the history
  4. all: release go-ethereum v1.13.11 (#28868)

    Release 1.13.11
    holiman authored Jan 24, 2024
    Configuration menu
    Copy the full SHA
    8f7eb9c View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. resolve conflicts

    ganeshvanahalli committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    6ad365e View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. do not turn off logging by default (useful for nitro tests) and updat…

    …e value field in beforeEVMTransfers and afterEVMTransfers of call_tracer inner_revert_reason.json to match correct values
    ganeshvanahalli committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    39f0d7b View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. make NewTxsEvent channel in simualted_beacon_api a buffered channel o…

    …f capacity 15, to prevent it from deadlocking on nitro-tests
    ganeshvanahalli committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    498311d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    64ea2d1 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Configuration menu
    Copy the full SHA
    cc9e427 View commit details
    Browse the repository at this point in the history